Improve extensibility of ERC1155
See original GitHub issue@KaiRo-at suggested that our current contract is not extensible enough due to using external
functions.
They also suggested to add an internal function that implements transfers to have a central extensibility point. I think this is fine but I would like to see the internal function use msg.sender
rather than having a sender
argument like we did in ERC20.
Issue Analytics
- State:
- Created 4 years ago
- Comments:13 (12 by maintainers)
Top Results From Across the Web
Create an ERC-1155 Collection without code | Rampp.xyz
Rampp's ERC-1155 contract allows you to continuously add new tokens and airdrop them to holders or even allow them to be claimed like...
Read more >ERC1155 DEX Trading [PART 3] - Medium
This will not only increase inter-game asset transfer, but also contribute to the spread of ERC 1155 tokens, and hopefully contribute to the...
Read more >RFC: Multi-Token Extensible NFT (Draft Spec) - Nervos Talk
ERC1155 was created a few months later to address these use cases. ... This improves interoperability of NFTs between token platforms ...
Read more >ERC - Ethereum Improvement Proposals
Ethereum Improvement Proposals (EIPs) describe standards for the Ethereum platform, ... 5750, General Extensibility for Method Behaviors, Zainan Victor Zhou ...
Read more >Highlight Smart Contracts: A Brief Overview - Mirror.xyz
The body: a modified template ERC1155 ... community can be considered as its own protocol (more on this in a future Extensibility post)....
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Hey all - I’d like to propose setting
virtual
touri
andisApprovedForAll
in the ERC1155.sol file. OpenSea currently relies on an override to the defaultisApprovedForAll
to permit use of a proxy address, and OpenSea relies onuri
returning theid
value concatenated to the URI.Hmm, if enough
virtual
s are spread throughout this and people can override those functions (I forgot for a moment that functions markedvirtual
do not actually require an override), then it may still work and be helpful, yes.