Only consider errors from the library functions in use
See original GitHub issueOur current checks will look at an entire library and consider it either upgrade safe or not. Due to this lack of granularity, a new function we wanted to introduce in the Address
utility library in OpenZeppelin Contracts 3.3 caused the entire library to be unusable with the upgrades plugins. (https://github.com/OpenZeppelin/openzeppelin-upgrades/issues/230)
We should only consider errors from those functions that are in use.
This opens an entire can of worms because we obviously need to consider errors from functions used indirectly (by the functions that are used directly, and so on transitively). The logic to implement this probably shares a lot with #159 so I would consider fixing both of these issues at the same time.
Issue Analytics
- State:
- Created 3 years ago
- Reactions:1
- Comments:10 (3 by maintainers)
Top Results From Across the Web
Is it okay to use errno for errors that my own functions might ...
I think it is a good idea to use errno. The larger the program the better it is if you use a standard...
Read more >Multiple includes of header only library causing redefinition ...
This library is self contained in one single header file and can be used either in header only mode or in implementation mode....
Read more >ERR30-C. Take care when reading errno
The value of errno may be set to nonzero by a C standard library function call whether or not there is an error,...
Read more >Rationale behind C library functions never setting errno to zero
The value of errno is 0 at program startup, but it is never set to 0 by any library function. The value of...
Read more >Checking for Errors (The GNU C Library)
2.1 Checking for Errors. Most library functions return a special value to indicate that they have failed. The special value is typically -1...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
@kevupton Sorry this is not trivial to fix which is why we haven’t done it yet.
Hi ! iam having the same issue when deploy a very basic contract. Is there any workaround ?