Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

IPv6 only hosts support

See original GitHub issue

If I’m right host identifier in trace is currently named ipv4 and encoded as int32 and used as integer throughout the system (column types, etc). This automaticaly disables ipv6 only hosts from being compatible with zipkin. Are there any plans or thoughts how one can add such support or maybe workaround can be found?

Issue Analytics

State:
Created 10 years ago
Comments:24 (8 by maintainers)

Top GitHub Comments

2reactions

tstumpfcommented, Jul 7, 2016

Endpoint.ipv6 as a binary seems like the best approach to us (chiming in for Twitter’s zipkin team).

Our rational being: the utility of Endpoint.address’ is uncertain but comes at a guaranteed cost for ipv6. The world is definitely moving to ipv6, it’s practically inevitable, and we can expect ipv6 to be the dominant case in the near future, so let’s optimize for it.

FWIW, a default of 0 for ipv4, that seems sane, but I don’t have any useful thoughts one way or the other about it.

cc @adriancole @mosesn

0reactions

codefromthecryptcommented, Jul 12, 2016

here’s the api definition change https://github.com/openzipkin/zipkin-api/pull/20