question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

add explicit traceId parameter to everything and fix leaky instrumentation

See original GitHub issue

Use of Tracer.setId is a bug. It has led to so many leaks and confusing “should I use scoped?” where the answer is everywhere due to routine use of Tracer.setId

While a v2 rewrite (which never allows this command) is a nice way out, it is unlikely a volunteer will muster the energy to do that, unless they have several weeks time.

Another way is to add a last parameter to everything with traceId, which allows explicit (leak-free) usage of the tracer. then, make the http instrumentation classes use that instead of perpetually leaking trace ids.

scoping should never be used for our instrumentation, in other words. scoping is only for third party code. let’s stop routinely using it, which will stop the routine bugs created in nearly every package.

Issue Analytics

  • State:open
  • Created 4 years ago
  • Comments:6 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
shumskycommented, Aug 5, 2019

@adriancole let me dig into this issue a little bit.

1reaction
codefromthecryptcommented, Jul 31, 2019

@openzipkin/core I don’t think we should do any more release on this repo until this issue is addressed. I spent weeks on this problem and we have a long history of silly bugs.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Add distributed tracing instrumentation - .NET - Microsoft Learn
A tutorial to instrument distributed traces in .NET applications. ... Add the static ActivitySource variable above Main() and using System.
Read more >
Getting Started with OpenTelemetry and Distributed Tracing in ...
Join Ted Young, Director of Developer Education at Lightstep, to learn how to get started with distributed tracing in Python using ...
Read more >
Node.js Agent version 3.x - Elastic
Fix a bug in span compression with sending spans that were buffered for possible compression. ... Add instrumentation for the undici HTTP client...
Read more >
Spring Cloud
The bootstrap context can be trained to do anything you like by adding entries ... files from a "spring.config.name" equal to the {application}...
Read more >
Changelog — Finagle 22.4.0 documentation
Previously, adding a Request cookie with the same name would overwrite the old value with the new value. PHAB_ID=D801466; finagle-postgres: Fixed a bug ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found