Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Library uses DateTime instead of DateTimeOffset resulting in +1 hour data

See original GitHub issue

Hi,

I normally use DateTimeOffset to ensure the real date never gets missed regardless of the local date. I see that DateTime gets used here and my guess was it just takes care of it but it seems it does not hence my traces are shown with +1 hour in zipkin.

Is there a design reason why DateTime gets used and not DateTimeOffset? I can send a PR but was wondering it could have another significance.

Thanks Ali

Issue Analytics

State:
Created 6 years ago
Comments:8

Top GitHub Comments

1reaction

codefromthecryptcommented, Aug 1, 2017

yeah much more clear.

FWIW most libraries don’t actually pass things like DateTime around anyway (rather numbers corresponding to epoch micros or a Clock facade that might be backed by something like DateTime).

If DateTime cannot be coerced to UTC, then sounds like a bad choice, but I’ll leave it to y’all decide what to do.

0reactions

aliostadcommented, Aug 1, 2017

Yeah, thanks I believe this should work. I am closing this issue.

Top Results From Across the Web

DateTime vs DateTimeOffset

DateTimeOffset is a representation of instantaneous time (also known as absolute time). By that, I mean a moment in time that is universal ......

Converting between DateTime and DateTimeOffset

Although the DateTimeOffset structure provides a greater degree of time zone awareness than the DateTime structure, DateTime parameters are used ...

4 Common Datetime Mistakes in C# And How to Avoid Them

In cases like this, it'd make more sense to either (a) store the datetime in UTC along with the user's time zone or...

The case against DateTime.Now - Code of Matt

If we are asking for DateTimeOffset.Now , we will get a value that represents the local time on the computer where the code...

datetime — Basic date and time types

Source code: Lib/datetime.py The datetime module supplies classes for ... The result is rounded to the nearest multiple of timedelta.resolution using ...