Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Create PR bot that reminds maintainers to check Story parity

See original GitHub issue

Feature

Why is this feature being added?

This will prevent human error in terms of merging changes to components without checking pre-existing stories for any needed changes.

What should your feature do?

Ensure that edits to components always match up with it’s Story (if it exists).

Defined as done:

I am unable to open a PR with code changed in components/ without a bot commenting to reminding maintainers to check the component’s corresponding Story for feature parity - if it exists.

Issue Analytics

State:
Created 5 years ago
Comments:14 (13 by maintainers)

Top GitHub Comments

1reaction

kylemhcommented, Oct 1, 2019

We’re going to move towards creating a component library where we won’t need to police this as much.

1reaction

IAMOTZcommented, Jul 30, 2019

Hi @kylemh Sorry for the late response, my days have been pretty busy. I’ve tried implementing your feedback by making the file paths and messages the app uses customizable. Now, you can have multiple file paths with different messages attached to them.

I also utilized the Github App Manifest to make it very easy for someone else to set up and install the app. I updated instructions to the README on configuring and testing the app.

Now, OperationCode can fork the repository from mine, configure it, deploy it, then install it in any of its repositories.

Looking forward to more feedback on my implementation and any contribution to make the app better.

Top Results From Across the Web

kentaro-m/pr-notify-bot - GitHub

A bot that reminds reviewers to review their pull requests. Feature. Automatic addition of reviewers to pull requests; Send notifications to Slack. Pull...

Auditing Pull Requests - The Carpentries

When you recieve a pull request, a check will first validate that the lesson can be built and then, if the lesson can...

Design: Automatically create a new merge request pipeline ...

We have a new feature POC that would address the problem in this issue, so the work on this issue has been paused...

Reimagine Challenge | Schmidt Futures

Fundraising app for regionalized small businesses that allows investors to search by location and business type to invest in companies from home regions....

Law Enforcement Intelligence: - Bureau of Justice Assistance

and other key stakeholders have created an environment in which Intelligence-. Led Policing and information sharing is more viable because of the strong....