question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add check to prevent storage layer importing domain layer or domain layer importing controller layer

See original GitHub issue

This is a tracking issue for the check to prevent storage layer, core/storage importing domain layer, core/domain or domain layer, core/domain importing controller layer, core/controllers.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:9 (9 by maintainers)

github_iconTop GitHub Comments

1reaction
seanlipcommented, Feb 7, 2019

I am fine either way. The only requirement is that nothing is merged to develop “halfway”, and I think both alternatives satisfy that.

Thanks for checking!

0reactions
YashJipkatecommented, Feb 7, 2019

@seanlip Ah okay then I’ll wait for @apb7 to review the already existing PR to verify my current approach since the same approach will do the second part too. Also I think it would be easier for him to review the subsequent changes for the same part fix which he reviewed earlier. And then when the existing PR gets an LGTM I’ll drop the other half of the fix 'coz then the class would be in develop, so the later fix will be less messy once I pull it. Thanks!

Read more comments on GitHub >

github_iconTop Results From Across the Web

Domain layer | Android Developers
The domain layer is responsible for encapsulating complex business logic, or simple business logic that is reused by multiple ViewModels. This  ...
Read more >
Implementing Domain Driven Design - ABP Documentation
This is a practical guide for implementing the Domain Driven Design (DDD). While the implementation details rely on the ABP Framework ...
Read more >
Domain-driven Design (DDD): File Structure
Infrastructure Layer: Is how data that is initially held by in the domain's entities (memory) is persisted in databases or another ...
Read more >
Security+ Domain 3.0 Implementation Flashcards - Quizlet
A network administrator is importing a list of certificates from an online ... It uses Secure Sockets Layer/Transport Layer Security (SSL/TLS) certificates.
Read more >
Multiple ways of defining Clean Architecture layers
We can check if imports of each class defined in the domain layer and flag and error if there are imortas that point...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found