Optimise code in profile_chooser_add_view.xml
See original GitHub issueThis issue is tracking the optimization work of profile_chooser_add_view.xml
-
Make sure that the layout uses
ConstraintLayout
and there is minimal nesting of views. If this view already usesConstraintLayout
then it’s fine. -
Make sure that all TextViews use the style from
styles.xml
file likeHeading1
,TextFieldLabel
,Body
, etc. whichever suits best.
While making the above changes the UI should not get affected and the end result should still be the same as before (or an optimized version of UI).
If there are multiple files with the same name, update them all.
References
Mobile Portrait: https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/grid/ Mobile Landscape: https://xd.adobe.com/view/ee9e607b-dbd6-4372-48dc-b687d32af3da-98af/grid/ Tablet: https://xd.adobe.com/view/d405de00-a871-4f0f-73a0-f8acef30349b-a234/grid/ Wiki: https://github.com/oppia/oppia-android/wiki/Working-on-UI
Issue Analytics
- State:
- Created 3 years ago
- Comments:10 (7 by maintainers)
Top GitHub Comments
Alright, thank you. I’ll review the screens, then go through the instructions again, if I have any questions, I’ll let you know.
On Tue, Dec 6, 2022 at 9:47 AM MOHIT GUPTA @.***> wrote:
@Uticodes assigned go ahead. If you have any query feel free to ask me.