Arrange string resources based on screens

Describe the bug

Currently string resources are not organised correctly and are scattered in strings.xml file.

This should be fixed by following these points:

1. Make sure that each string is getting used in one specific view only. For example Home is part of multiple views like Navigation Drawer, Home-Toolbar. So for this we should have separate strings for both.
2. All strings related to one activity/fragment should be kept together by mentioning the activity name on top of the strings in a comment. Example: <!-- ProfileResetPinActivity -->
3. All activities/fragment sections should be in correct alphabetical order based on activity/fragment name. (The actual strings name are not required to be in alphabetical order but the comments should be in alphabetical order). Example:

<!-- HomeActivity -->
<string name="random_string_related_to_home">ABC</string>
<!-- ProfileResetPinActivity -->
<string name="random_string_related_to_profile_resent_pin">ABC</string>
<string name="random_string_related_to_profile_resent_pin_2">XYZ</string>

[rt4914]

@rt4914 It would be very helpful if you can clarify these doubts before I get started:

1. What comments do we put over Strings that are used nowhere but only declared?

If a string is not getting used anywhere, it should be removed.

1. What comments do we put over Strings that are only used in a resource XML like menu? Do we create separate Strings if they are repeated in several resource files?

Don’t create separate strings right now. If its needed I will mention in PR. Comments can be related to menu file where they are getting used.

1. For Activities and Fragments, do we put both XML and Kotlin Strings under the same comment?

Yes, a list of strings should be combined based on screen/feature and not on file-to-file basis.

1. What about Strings used in Test files?

It would be great if they start with test_ prefix.

Sorry for the barrage of questions. There’s a lot of Strings and I don’t yet understand the issue properly. If it’s easier for you, we could do a meet.

The replies might change in PR because here I don’t have exact example with your questions. So I think better you create a PR with your judgement and there the conversation can be a bit easy. Thanks.

[adizcode]

I would like to work on this.