Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Fix Mathematical Naming in classify rules

See original GitHub issue

Describe the bug Some of the variables naming related to numbers in src/main/java/org/oppia/android/domain/classify/rules and it’s test packet are mathematical incorrect. example - NEGATIVE_WHOLE_NUMBER_VALUE_TEST_2 where a whole number cannot be negative.

Expected behavior Need to fix all such variables name

Follow these comments to solve this issue - https://github.com/oppia/oppia-android/pull/2443#issuecomment-758299254 Reach out to @anandwana001 before start working on this.

How to work on this issue

Suggesting few points below on how to solve this particular issue:

Let’s have a doc where you can list all the types of the number we have.
Specify the rules based on those numbers. Example - A whole number can’t be negative.
You can add rules for all the types of number like a fraction, mixed fraction, Ratio of numbers etc…
After completing with doc, either we can fix everything in this PR, but I guess it might make this PR big, so we can divide it into multiple sub-issues.

Issue Analytics

State:
Created 3 years ago
Comments:10 (9 by maintainers)

Top GitHub Comments

1reaction

anandwana001commented, Jan 7, 2021

@codersanjeev please complete the onboarding instructions before starting with the contributions. https://github.com/oppia/oppia-android/wiki

0reactions

yash10019codercommented, Feb 10, 2022

you can start from domain/java/test(that green folder)/classify/rules/fractionalinput/ link

In this you can find some classes try to find the names which seems odd mathematically like an whole number integer in this the thing wrong is it should either be a whole number or a integer so try to find these names in the files and fix them

Top Results From Across the Web

How to classify name polynomials by degree and number of ...

Business Contact: mathgotserved@gmail.com Chapters0:00 Introduction0:39 Classification chart by Name monomial binomial trinomial2:51 ...

Math in the Preschool Classroom Classification, Matching ...

In this fact sheet we focus on the math skills of classification, matching, seriation and patterning.

Mathematicians Solve Decades-Old Classification Problem

A pair of researchers has shown that trying to classify groups of numbers called “torsion-free abelian groups” is as hard as it can...

Classification in Math - Preschool Math - Twinkl USA

Simple classification math definition. Classification is where objects are systematically organized into groups according to fixed criteria.

Classifying and Sorting - Play Within Early Years Classrooms

Classification is a fundamental pre-number learning concept that children learn ... is needed for higher mathematical thinking in Pre-primary and year 1.