Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Make dimens value follow one naming convention

See original GitHub issue

All dimens in app modules should follow below mentioned convention:

1_66JEKhu7WqtPMkjegXMmgQ

In this image, I suggest instead of using padding_24dp and margin_24dp, combining them to space_24dp. So basically all padding/margins should be combined to space_<value>. This was we will have to add lesser values to dimens file.

Image Reference

Issue Analytics

State:
Created 3 years ago
Comments:7 (7 by maintainers)

Top GitHub Comments

1reaction

rt4914commented, Sep 5, 2020

@rt4914 Hey can I please work on this issue if no one else is working on it.

Assigned.

0reactions

rt4914commented, Sep 16, 2020

@rt4914 Hey Rajat should I also replace all the hardcoded dimensions with dimens values

@ranjsa No, you should just focus on renaming the existing ones to match the convention correctly. Also, I have updated the description, have a look.

Top Results From Across the Web

Android — Dimensions by Conventions | by Pravin Sonawane

In this article, we will see a simple approach to use 'conventions' for dimension resources on Android. But the same conventions can be...

Naming Conventions for Attribute Calculations Dimension ...

In unique member outlines that contain an attribute dimension (and, therefore, an Attribute Calculations dimension), do not use the following names unless ...

How to use dimens.xml in Android? - Stack Overflow

Create a new dimens.xml file by right clicking the values folder and choosing New > Values resource file. Write dimens for the name....

Conventions for managing dimension resources on android ...

Over the years, I've found myself creating a lot of redundant dimension resources like item_margin, product_left_margin, etc. which all have ...

A successful XML naming convention - Jeroen Mols

For IDs, <WHAT> is the class name of the xml element it belongs to. Next is the screen the ID is in, followed...