Merge app_language_fragment into single xml file
See original GitHub issueCurrently there are 3 versions of app_language_fragment.xml
file merge it into single xml file.
For merging this better shift the toolbar
from mobile qualifier files to app_language_activity.xml
so that the app_language_fragment
will contain only the RecyclerView
which can we easily used in mobile as well as tablet.
This will need changes in respective kotlin files and test files too.
We can use https://text-compare.com/ to compare two versions of this file and for all the differences we can create variables in dimens.xml
file and use it accordingly.
Note: In PR, make sure you add before and after screenshot of mobile-portrait, mobile-landscape, tablet-portrait and tablet-landscape for comparison and make sure that there is not difference between before and after UI.
Issue Analytics
- State:
- Created 2 years ago
- Comments:7 (7 by maintainers)
Top GitHub Comments
Tried working on it but facing issues of injection and binding in kt file, learning these concepts but unassigning it to avoid any delay in issue solving.
Assigned to you @bhaktideshmukh thanks