Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Merge walkthrough_welcome_fragment.xml into single xml file

See original GitHub issue

Currently there are 2 versions of walkthrough_welcome_fragment.xml file merge it into single xml file.

We can use https://text-compare.com/ to compare two versions of this file and for all the differences we can create variables in dimens.xml file and use it accordingly.

Note: In PR, make sure you add before and after screenshot of mobile-portrait, mobile-landscape, tablet-portrait and tablet-landscape for comparison and make sure that there is not difference between before and after UI.

Issue Analytics

State:
Created 2 years ago
Comments:22 (10 by maintainers)

Top GitHub Comments

1reaction

ShivamMadlanicommented, Mar 28, 2022

Can you assign me this issue?

0reactions

kemickycommented, May 17, 2022

I left it when I heard no response from you. Nobody reached out to me or communicate to me on how to proceed. So I left it. I did it already but when I wasn’t get any form of response I thought maybe it’s not needed anymore.

On Wed, 11 May 2022, 2:25 pm Rajat Talesra, @.***> wrote:

Closing this as we cannot merge files for this layout considering both the layouts are designed differently.

— Reply to this email directly, view it on GitHub https://github.com/oppia/oppia-android/issues/3591#issuecomment-1123690541, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANU6V7SWIXFFOMTW3V5OURTVJORLHANCNFSM5BB47FUQ . You are receiving this because you commented.Message ID: @.***>