Migration to TextInputLayout from ProfileInputView
See original GitHub issueIs your feature request related to a problem? Please describe.
Currently, we are using ProfileInputView
which seems not able to perform a few things like testing for IME action and a ProfileInputView
is itself a custom view which makes it hard to modify or introduce new features.
Describe the solution you’d like
Introducing TextInputLayout
seems promising.
How to submit PR for this issue
- Update all the XML files related to its screen (port/land/sw600dp/sw600dp-land)
- Add all the screenshots (port/land/sw600dp/sw600dp-land) for (showing hint/softkeyboard visible/input/error)
- Add Video (now GitHub support uploading of
.mp4
or.mov
) - Add kdocs wherever needed, reference - https://kotlinlang.org/docs/reference/kotlin-doc.html
- Run Test of screen-specific file on both Espresso and Robolectric and all test cases should pass including tests if there are any ignored saying ignored because of IME actions
Screens to migrate
- AdminAuth (@anandwana001)
- AddProfile (@FareesHussain)
- ProfileRename (@FareesHussain)
- AdminPin (@prayutsu)
- AdminSettings (@FareesHussain)
- ProfileResetPin (@FareesHussain)
- ResetPinDialog (@FareesHussain) … more to add
Issue Analytics
- State:
- Created 3 years ago
- Comments:8 (8 by maintainers)
Top Results From Across the Web
TextInputLayout | Android Developers
Layout which wraps a TextInputEditText , EditText , or descendant to show a floating label when the hint is hidden while the user...
Read more >android.support.design.widget.TextInputLayout could not be ...
TextInputLayout In my android application. I have copied the jar file android-support-design.jar from the sdk to my applications lib folder.
Read more >Android TextInputLayout Example | DigitalOcean
In this tutorial, we'll be looking in depth at the features that Android TextInputLayout provides us. Android TextInputLayout is a design ...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
@anandwana001 I feel we have included all files that use
ProfileInputView
ah, It looks like
AdminSettings
andResetPinDialog
both covered in PR https://github.com/oppia/oppia-android/pull/2349