Lightrun
question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Nit code change in HomeActivityTest.kt

See original GitHub issue

HomeActivityTest.kt needs to be updated as per this comment https://github.com/oppia/oppia-android/pull/2246#discussion_r559335629

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
yurilevcommented, Jan 29, 2021

Hi Farees, I already did all that.

0reactions
yurilevcommented, Jan 30, 2021

The nit was for testHomeActivity_allTopicsCompleted_displaysAllTopicCards(), which appears to be broken on tablets, expecting the wrong number of columns. Similar tests in the same file have 4 versions, for mobile/tablet and portrait/landscape.

May I fix the test and make related improvements as part of this, or should I file a separate issue?

Filed #2587.

Read more comments on GitHub >

github_iconTop Results From Across the Web

AarogyaSetu_Android/HomeActivityTest.kt at master - GitHub
Aarogya Setu Android app native code. Contribute to nic-delhi/AarogyaSetu_Android development by creating an account on GitHub.
Read more >
The Standard of Code Review | eng-practices - Google
First, developers must be able to make progress on their tasks. If you never submit an improvement to the codebase, then the codebase...
Read more >
Android Studio "No tests were found" - Stack Overflow
With me, this goes wrong when running an Espresso test which used to be a unit test. For some reason it still uses...
Read more >
nit: Fix your team's code review participation issues - Medium
Let's take another PR containing 1 file with 3 lines of code change and each line associating to a different bug fix. In...
Read more >
Code Review Guidelines - GitLab Docs
We are not introducing changes to the reviewer roulette till we evaluate the impact and feedback from this experiment. We ask to respect...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found
Previous page

Update literals to named arguments in TopicLessonsFragmentTest.kt

Next page

Tests Failing on Espresso in Landscape with small screen size or bug