question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

No enough padding on Continue button style

See original GitHub issue

Describe the bug Continue has not enough padding when reading size changed to Extra Large

To Reproduce Steps to reproduce the behavior:

  1. Go to ‘Navigation menu’ -> Select Option
  2. Click on ‘Reading text size’ -> Select Extra Large
  3. Open any lesson
  4. Scroll down to click on Continue

Expected behavior Continue button should have good padding from both ends.

Demonstration If applicable, add screenshots or videos to help explain your problem. oppia_issue

Environment

  • Device/emulator being used: Pixel 4 XL
  • Android or SDK version: API Level 27
  • App version: 1.0

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:12 (9 by maintainers)

github_iconTop GitHub Comments

1reaction
rt4914commented, Aug 31, 2022

@Chandra-Sekhar-Bala Yes adding padding is a better way to solve this. Basically follow these guidelines:

  • Avoid giving fixed width/height
  • Add padding to all sides of text – inside button
  • Use sp for textsize and dp for everything else.

These guidelines should be sufficient to solve this issue.

1reaction
Chandra-Sekhar-Balacommented, Aug 21, 2022

Hey @BenHenning Yes, I have checked it is on the latest version. Steps are mentioned to reproduce the bug, you can verify.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Styling The Good Ol' Button Element - Ahmad Shadeed
Don't Forget Padding. It might be tempting to not add horizontal padding for the button since it has a width and there is...
Read more >
Padding inside a button element not removable - Stack Overflow
In the fiddle, the button is not high enough for the text. But that is easily fixed by adding line-height:0 to the CSS....
Read more >
Overriding Default Button Styles | CSS-Tricks
Just by setting the font-size, we lose all those defaults, but it's got a new default look, one with a border and square...
Read more >
2007/2010/2013/2016 Outlook button padding #416 - GitHub
The problem with buttons is that padding does not work in Outlook for p , a , and div elements. A quick fix...
Read more >
How to Apply CSS Padding Around Your Website's Elements
Buttons are usually the element used for calls-to-action, so padding them appropriately makes them stand out just enough for a user to click....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found