question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Resolve ktlint max line in player test package

See original GitHub issue

Describe the bug We are preventing the 100 char length at some places like test case fun name. // ktlint-disable max-line-length

Expected behavior We need to remove this prevention and fix the function name under 100 char length.

Where to start? https://github.com/oppia/oppia-android/blob/d2d55013605d318965594932b9224578cbc9a586/app/src/sharedTest/java/org/oppia/android/app/player/exploration/ExplorationActivityTest.kt#L291

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:7 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
anandwana001commented, Feb 1, 2021

we use configChange, IsDisplayed in place of shows.

fun testStateFragment_loadExp_configChange_buttonIsNotDisplayed()
fun testAudioFragment_hindiAudioLangProfile_hindiAudioLangIsDisplayed()

A draft PR will be helpful for such a discussion.

1reaction
nskirkeycommented, Jan 7, 2021

I was hoping to assigned to this. I was assigned the unsplit PR and had been working on a script to help me go thru and fix the fun names.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Max line length · Issue #47 · pinterest/ktlint - GitHub
I would like to enforce a maximum line length on the files being linted. I'm partial to 100 characters, or even 120.
Read more >
KtLint configuration
Only the maximum line length determines when a function signature should be written on a single line or with multiple lines. Setting ...
Read more >
platform/external/ktlint - Git at Google
While this might sound extreme, keep in mind that ktlint tries to capture (reflect) ... (unless used to separate multiple statements on the...
Read more >
ktlint not checking kotlin file - Stack Overflow
I want my project to perform ktlintCheck on all kotlin file, but it only check on build.gradle.kts ...
Read more >
homebrew-core - Homebrew Formulae
a2ps 4.14 Any‑to‑PostScript filter aacgain 1.8 AAC‑supporting version of mp3gain aalib 1.4rc5 Portable ASCII art graphics library aamath 0.3 Renders mathematical expressions as ASCII art
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found