question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Shift NumericInput Rules test to separate sub-package

See original GitHub issue

NumericInputEqualsRuleClassifierProviderTest.kt NumericInputIsLessThanRuleClassifierProviderTest.kt NumericInputIsLessThanOrEqualToRuleClassifierProviderTest.kt NumericInputIsInclusivelyBetweenRuleClassifierProviderTest.kt NumericInputIsGreaterThanRuleClassifierProviderTest.kt NumericInputIsGreaterThanOrEqualToRuleClassifierProviderTest.kt

Shift all these to separate package named numberinput in https://github.com/oppia/oppia-android/tree/develop/domain/src/test/java/org/oppia/android/domain/classify/rules

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:9 (9 by maintainers)

github_iconTop GitHub Comments

1reaction
rt4914commented, Sep 29, 2020

@rt4914 we don’t run or build Bazel tests in CI currently. Strictly speaking, #3 isn’t a hard requirement. I actually only noticed these issues because I was building the Bazel tests locally and it took me a bit to figure out why they weren’t building. 😃 We should fix the Bazel file now that we know it’s not setup correctly anymore, and try to keep them up-to-date when we remember.

I’m working on adding the builds to CI, but it’s running into some performance hiccups: #1904.

Does this help clarify?

Makes sense. My only concern was about missing changes in bazel file. Thanks for clarification.

0reactions
BenHenningcommented, Sep 29, 2020

@rt4914 we don’t run or build Bazel tests in CI currently. Strictly speaking, #3 isn’t a hard requirement. I actually only noticed these issues because I was building the Bazel tests locally and it took me a bit to figure out why they weren’t building. 😃 We should fix the Bazel file now that we know it’s not setup correctly anymore, and try to keep them up-to-date when we remember.

I’m working on adding the builds to CI, but it’s running into some performance hiccups: https://github.com/oppia/oppia-android/pull/1904.

Does this help clarify?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Where to put tests for subpackages in python? - Stack Overflow
Create a separate test folder in each subpackage and place its tests there. Duplicate the package hierarchy in the top-level test folder, ...
Read more >
Testing subpackages · Issue #152 · cucumber/godog - GitHub
godog uses go to compile test files and go supports testing only single package once, when you run go test ./... it would...
Read more >
Subpackages - Real Python
In this video, you'll explore subpackages. Packages can be nested to contain subpackages, and that can be done to an arbitrary depth.
Read more >
Decision Logic Development | Pega Community
Decision logic components (page 196) work on information from the input record. The input data can represent anything that is pertinent, for example:....
Read more >
ChangeLog-SLE-15-SP3-GM-SLE-15-SP4-PublicBeta ... - SUSE
fix bluez-auto-enable-devices subpackage (boo#1177845) - add bluez-test-2to3.diff to get rid of python2 dependency - remove notification message from ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found