Removing un-used fonts directory in third_party/generated.
See original GitHub issueIn third_party/generated
we have fonts
which is currently used by bootstrap-3
only to store glphyicons
fonts. Earlier it was used by font-awesome-4
also but after upgrading tofont-awesome-5
now it uses web_fonts
directory due to change in its directory structure.
After upgrading to bootstrap-4 as don’t use glphyicons the fonts directory should be empty considering that no new lib is added which stores data in fonts directory.
if the fonts dir is empty after the migrating to bootstrap-4 it can be removed in the scripts/build.py
which builds and creates the third_party/generated folders
and copy/combines all the library files
To learn more about it see the comments in the PR #6789 & in this doc
First remove the _generate_copy_tasks_for_fonts
for the fonts folder which excutes in build_third_party_libs()
of build.py and then remove all the FONTS_RELATIVE_DIRECTORY_PATH
& FONT_DIR
at the needed places and update the fontspath
in manifest.json
This needs good testing for the safe removal of the fonts
folder, please do check all the console log at places for any 404 error through fonts directory, cross-check manifest.json if there is not library using fonts
as fontspath
Issue Analytics
- State:
- Created 4 years ago
- Comments:8 (5 by maintainers)
Top GitHub Comments
@khansaAmrouni Hi, I have assigned you! If you have any questions don’t hesitate to ask here.
Fixed in #7978