question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Renaming rule for DragDropAndSort Interaction

See original GitHub issue

One of the rules of DragDropAndSort Interaction seems to be incorrectly named. https://github.com/oppia/oppia/blob/6ef62595b5dabadc280ddf9a11760eccf7d84cae/extensions/interactions/DragAndDropSortInput/directives/drag-and-drop-sort-input-rules.service.ts#L82 Currently, it is IsEqualToOrderingWithOneItemAtIncorrectPosition but i think it should be IsEqualToOrderingWithOneItemIncorrect.

What wrong with current name First of all, if we talk about a list there can never be a single item which is at an incorrect position there would always be at least 2 items which are at an incorrect position For example - let’s consider this list [['a', 'b'], ['c'], ['de', 'f']] so if we want to talk about an incorrect position of item there can be 2 cases

  1. outer item is an incorrect position - [['c'], ['a', 'b']], ['de', 'f']
  2. inner item is an incorrect position - [['b', 'a'], ['c'], ['de', 'f']] In both cases, there are always 2 items which are at incorrect position so it can’t be the case anyhow.

Proposed solution So based upon the current tests for the above rule I suggest it should be something like IsEqualToOrderingWithOneItemIncorrect and that is because there can be the case when the grouping of items are allowed and user clubbed the incorrect item for example - let consider this [['a', 'b'], ['c'], ['de', 'f']]
and assume that the user tries to submit an answer something like [['a', 'b'], ['c', 'f']], ['de'] in this case the one of the item is incorrect rather than it’s the position.

Issue Analytics

  • State:open
  • Created 3 years ago
  • Comments:10 (10 by maintainers)

github_iconTop GitHub Comments

1reaction
seanlipcommented, Jul 23, 2020

Yes, certainly! No hurry.

0reactions
aggarwalpulkit596commented, Jul 23, 2020

I would love to work on this and can probably figure out the issues with more ease because I spent last month doing the same interaction on android but unfortunately, I’m already running low on time for GSoC work.

Can I take this up post-GSoC?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Create a payee renaming rule - Quicken Help Site
In the register, select a transaction from the payee you want to rename. Type a new name for the payee in the Payee...
Read more >
Defining Renaming Rules - ProKnow
Use renaming rules to automatically rename structures matching your criteria for future imports or execute a renaming operation on data that has ...
Read more >
The Outliner, please dear god the Outliner - Paradox Forum
Yes please! The lack of this has lead to me renaming my planets for what they do rather than keeping the unique names...
Read more >
Dividing Fractions Quiz Teaching Resources - TPT
This assessment has 20 questions, asking students to multiply fractions, divide fractions, and find the reciprocal of fractions. Includes ...
Read more >
Java > Daily News & Articles > 2012 > 01 - KickJava.com
soa.sys-con.com; Why Rule-Based Log Correlation Is Almost a Good Idea: ... lightweight JavaScript library for interactive maps by CloudMade
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found