Renaming rule for DragDropAndSort Interaction
See original GitHub issueOne of the rules of DragDropAndSort Interaction seems to be incorrectly named.
https://github.com/oppia/oppia/blob/6ef62595b5dabadc280ddf9a11760eccf7d84cae/extensions/interactions/DragAndDropSortInput/directives/drag-and-drop-sort-input-rules.service.ts#L82
Currently, it is IsEqualToOrderingWithOneItemAtIncorrectPosition
but i think it should be IsEqualToOrderingWithOneItemIncorrect
.
What wrong with current name
First of all, if we talk about a list there can never be a single item which is at an incorrect position there would always be at least 2 items which are at an incorrect position
For example -
let’s consider this list [['a', 'b'], ['c'], ['de', 'f']]
so if we want to talk about an incorrect position of item there can be 2 cases
- outer item is an incorrect position -
[['c'], ['a', 'b']], ['de', 'f']
- inner item is an incorrect position -
[['b', 'a'], ['c'], ['de', 'f']]
In both cases, there are always 2 items which are at incorrect position so it can’t be the case anyhow.
Proposed solution
So based upon the current tests for the above rule I suggest it should be something like IsEqualToOrderingWithOneItemIncorrect and that is because there can be the case when the grouping of items are allowed and user clubbed the incorrect item for example -
let consider this [['a', 'b'], ['c'], ['de', 'f']]
and assume that the user tries to submit an answer something like [['a', 'b'], ['c', 'f']], ['de']
in this case the one of the item is incorrect rather than it’s the position.
Issue Analytics
- State:
- Created 3 years ago
- Comments:10 (10 by maintainers)
Top GitHub Comments
Yes, certainly! No hurry.
I would love to work on this and can probably figure out the issues with more ease because I spent last month doing the same interaction on android but unfortunately, I’m already running low on time for GSoC work.
Can I take this up post-GSoC?