Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Stop usage of gae_id attribute in UserSettingsModel.

See original GitHub issue

We have a new UserAuthDetailsModel to store the authentication detail gae_id now, and PR #10123 introduced a) domain methods for populating it for the new users and, b) a migration job for populating it for existing users. Post that, there are following cleaning tasks to be performed.

Stop using gae_id in UserSettingsModel i.e Remove gae_id attribute from UserSettingsModel. Reason for this task: We no longer use the attribute in this class (More context: In PR #10241, get_by_gae_id method was removed from UserSettingsModel - see here). Places to work on should be located by finding the TODO(#10178) in the PR #10123 asking to remove the gae_id as a required attribute. It will also involve changes at places where we assumed UserAuthDetailsModel could be None for an existing user.
Removal of PopulateUserAuthDetailsModelOneOffJob migration job which was also introduced in PR #10123. It successfully did its job, and is no longer needed.

Issue Analytics

State:
Created 3 years ago
Comments:8 (8 by maintainers)

Top GitHub Comments

1reaction

vojtechjelinekcommented, Nov 4, 2020

It will be run at the end of November, I will close it then.

0reactions

sajalasaticommented, Nov 4, 2020

@vojtechjelinek Can you confirm that the job ran successfully on the production so that we can close this issue?

Top Results From Across the Web

Toggle input disabled attribute using jQuery - Stack Overflow

$('#el').prop('disabled', (i, v) => !v);. The .prop() method accepts two arguments: Property name (disabled, checked, selected) anything that is either true ...