Stop usage of gae_id attribute in UserSettingsModel.
See original GitHub issueWe have a new UserAuthDetailsModel
to store the authentication detail gae_id
now, and PR #10123 introduced a) domain methods for populating it for the new users and, b) a migration job for populating it for existing users. Post that, there are following cleaning tasks to be performed.
- Stop using
gae_id
inUserSettingsModel
i.e Removegae_id
attribute fromUserSettingsModel
. Reason for this task: We no longer use the attribute in this class (More context: In PR #10241,get_by_gae_id
method was removed fromUserSettingsModel
- see here). Places to work on should be located by finding the TODO(#10178) in the PR #10123 asking to remove thegae_id
as a required attribute. It will also involve changes at places where we assumedUserAuthDetailsModel
could beNone
for an existing user. - Removal of
PopulateUserAuthDetailsModelOneOffJob
migration job which was also introduced in PR #10123. It successfully did its job, and is no longer needed.
Issue Analytics
- State:
- Created 3 years ago
- Comments:8 (8 by maintainers)
Top Results From Across the Web
Toggle input disabled attribute using jQuery - Stack Overflow
$('#el').prop('disabled', (i, v) => !v);. The .prop() method accepts two arguments: Property name (disabled, checked, selected) anything that is either true ...
Read more >Common Function Attributes (Using the GNU Compiler ...
Note that the access attribute merely specifies how an object referenced by the pointer argument can be accessed; it does not imply that...
Read more >Attributes in Clang — Clang 16.0.0git documentation
On 32-bit x86 targets, this attribute changes the calling convention of a function to use ECX and EDX as register parameters and clear...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
It will be run at the end of November, I will close it then.
@vojtechjelinek Can you confirm that the job ran successfully on the production so that we can close this issue?