Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add more test cases in `optuna/visualization/matplotlib/*.py`

See original GitHub issue

Motivation

Currently, test cases in optuna/visualization/matplotlib/*.py are not enough comparing to optuna/visualization/*.py. For example, in the case of optuna/visualization/matplotlib/edf.py, we should check the number of lines and titles of each figure as we fixed them in https://github.com/optuna/optuna/pull/2642.

Description

test_contour.py (https://github.com/optuna/optuna/pull/2806)
test_edf.py (https://github.com/optuna/optuna/pull/2642)
test_intermediate_plot.py (https://github.com/optuna/optuna/pull/2754)
test_optimization_history.py (https://github.com/optuna/optuna/pull/2761)
test_parallel_coordinate.py (https://github.com/optuna/optuna/pull/2778)
test_param_importances.py (https://github.com/optuna/optuna/pull/2774)
test_pareto_front.py (https://github.com/optuna/optuna/pull/2763)
test_slice.py (https://github.com/optuna/optuna/pull/2764)

Issue Analytics

State:
Created 2 years ago
Comments:14 (10 by maintainers)

Top GitHub Comments

1reaction

01-vyomcommented, Jul 16, 2021

Thank you for sharing that! In my understanding, both get_yaxis and get_yaxis don’t show any warning message now, so it is okay as in Optuna codebase. But following matplotlib’s document is supposed to be great for dev-members or contributors. So please feel free to send a PR if you want!

Ok, will make a PR once this issue is closed.

1reaction

01-vyomcommented, Jul 2, 2021

Working on test_parallel_coordinate.py