question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Make a consistent policy for instantiation of storage classes and publicization of private storage accompanying it

See original GitHub issue

blocked by https://github.com/optuna/optuna/issues/2938

Motivation

Currently, CachedStorage and InMemoryStorage are private to users, and it is not expected that users will instantiate them directly using their constructors. However, the handling of instances is inconsistent in the following points:

  • RDBStorage and RedisStorage are public and are expected to be instantiated by users. Otherwise, these two classes cannot specify their functionality by the string argument.
  • Since trial.storage is public, we can access any instance of storage via the public API.

It is necessary to determine a consistent policy for instantiation of the all storage classes, and to determine their accesses (public/private) of CachedStorage and InMemoryStorage based on it.

Description

The policy will be decided in consideration of the following points. Also, the changes have been merged.

  • Consistent policy for instantiation of the all storage classes
  • Based on that, their accesses (public/private) of CachedStorage and InMemoryStorage have been decided.

TODOs

  • Decide consistent policy for instantiation of the all storage classes
  • Their accesses (public/private) of CachedStorage and InMemoryStorage have been decided.
  • Implementation

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

4reactions
keisuke-umezawacommented, Feb 15, 2022

@himkt You are right! But, to close this issue, I need to summarize the situation beforehand. Wait a moment for it.

0reactions
HideakiImamuracommented, Mar 28, 2022

Thanks for the summarization. I think this Issue is fine to close. Please let me do that.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Optuna V3 Roadmap
Consistent policy for instantiation of all storage classes. Based on that, their accesses (public/private) of _CachedStorage and InMemoryStorage ...
Read more >
Create Storage Classes by Using the Custom ...
To create a storage class that you can apply to data objects, create the storage ... In the Header file drop-down list, change...
Read more >
Managing and allocating storage resources ...
Read this document to understand how to create, configure, and allocate storage to core services or hosted applications in Red Hat OpenShift Container...
Read more >
Amazon Simple Storage Service (S3) - AWS
All of these storage classes are backed by the Amazon S3 Service Level Agreement. ... Private Cloud (Amazon VPC) endpoint policies, service control...
Read more >
Amazon S3 FAQs
Q: What is the consistency model for Amazon S3? Amazon S3 delivers strong read-after-write consistency automatically for any storage request, ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found