Enable SQL CREATE PROPERTY to set ATTRIBUTES such as NOT NULL, MANDATORY, and READONLY

Presently quite a few commands are required to create a property in a class that is “not null”, “mandatory”, or “read only”. For example:

CREATE Property User.username STRING
ALTER PROPERTY User.username MANDATORY true
ALTER PROPERTY User.username NOTNULL true
ALTER PROPERTY User.username READONLY true

It would be convenient to be able to do the following (or a mix of the attributes):

CREATE Property User.username STRING MANDATORY NOTNULL READONLY

These attributes would come at the end of the statement. For example if this property was a linked element:

CREATE Property Employee.supervisor LINK Employee MANDATORY NOTNULL READONLY

This would make defining properties in SQL much more succinct. Other properties could be defined as well (DEFAULT, MIN, MAX, etc.). It appears that this change could be made in the OCommandExecutorSQLCreateProperty parse and execute methods.

If this seems like a good feature, I would be willing to create a PR.

[luigidellaquila]

Little Bobby Tables is always in my heart 😆

I think UNSAFE just didn’t work 😉 What I’m trying to do with the new grammar is to make things as strict as possible, to avoid corner cases and have predictable behavior.

Adding new reserved keywords is an option, but it can make migrations very tricky, so I always try to avoid it if I can, in this case I think commas are an acceptable alternative.

Thanks

Luigi

[francisco1844]

Thanks for the feedback @mmacfadden. Will create a new issue.