NPE in ORecordSerializerBinaryV0

There is the following code in ORecordSerializerBinaryV0

  private int writeEmbeddedMap(BytesContainer bytes, Map<Object, Object> map) {
    final int[] pos = new int[map.size()];
    int i = 0;
    Entry<Object, Object> values[] = new Entry[map.size()];
    final int fullPos = OVarIntSerializer.write(bytes, map.size());
    for (Entry<Object, Object> entry : map.entrySet()) {
      // TODO:check skip of complex types
      // FIXME: changed to support only string key on map
      OType type = OType.STRING;
      writeOType(bytes, bytes.alloc(1), type);
      writeString(bytes, entry.getKey().toString());
      pos[i] = bytes.alloc(OIntegerSerializer.INT_SIZE + 1);
      values[i] = entry;
      i++;
    }

The problem is that some Maps can contains nulls as keys. So there will be NPE here: entry.getKey().toString().

[PhantomYdn]

Yea - you can define as you wish: but during deserialization, I guess it should be transformed back to null. Right? If it’s not possible: I think that OrientDB should transform null into “” (empty string) key.

[tglman]

hi @PhantomYdn,

double checking the fix i did the exception go up in any case of set of a null value on a tracked map, this for me is more than enough.

Closing