Passing quoted strings to methods removes quotes.

Expected behavior and actual behavior

When passing a quoted string to a function the function should use the quoted version of the string. Instead the quotes seem to be stripped.

Steps to reproduce the problem

Run the following SQL.

DROP CLASS test;
CREATE CLASS test;
CREATE PROPERTY test.id String;
CREATE PROPERTY test.value String;

INSERT INTO test SET id = "1", value = "Test 1: ";
UPDATE test SET value = value.append("\"double quotes\"") WHERE id = "1";

INSERT INTO test SET id = "2", value = "Test 2: ";
UPDATE test SET value = value.append("'single quotes'") WHERE id = "2";

INSERT INTO test SET id = "3", value = "Test 3: ";
UPDATE test SET value = value.append("\"mixed quotes'") WHERE id = "3";

INSERT INTO test SET id = "4", value = "Test 4: ";
UPDATE test SET value = value.append("\"one quote") WHERE id = "4";

INSERT INTO test SET id = "5", value = "Test 5: ";
UPDATE test SET value = value.append("\"nested \"quotes\" in quotes\"") WHERE id = "5";

SELECT * FROM test;

Output:

Test 1: double quotes

• Both surrounding quotes are stripped

Test 2: single quotes

• Both surrounding quotes are stripped

Test 3: "mixed quotes’

• Both quotes left

Test 4: "one quote

• preceding quote intact

Test 5: nested “quotes” in quotes

• Outer quotes are stripped, inner quotes are left.

It seems that this might be a parser issue given the sensitivity to matched quotes and the fact that only outer quotes are being stripped. This is not unique to the append method, it also was noted in “right”, and “substring” as well.

Also, when doing an INSERT, the quotes seem to be just fine, so it appears to be related to quoted strings passed to functions.

Important Questions

None

Runninng Mode

• Embedded, using PLOCAL access mode
• [ X] Embedded, using MEMORY access mode
• Remote

Misc

• I have a distributed setup with multiple servers. How many?
• I’m using the Enterprise Edition

OrientDB Version

• v2.0.x - Please specify last number:
• v2.1.x - Please specify last number:
• [X ] v2.2.x - Please specify last number: 2.2.0

Operating System

• Linux
• [ X] MacOSX
• Windows
• Other Unix
• Other, name?

Java Version

• 6
• 7
• [ X] 8

[luigidellaquila]

Hi @mmacfadden

I pushed a fix on both 3.0 and 3.1 branches

Thanks

Luigi

[mmacfadden]

@luigidellaquila Thanks!