Marker Popup (Info Window) Remains Open After Marker Is Removed From Map

Issue Type

[ x ] Bug

Description and/or steps/code to reproduce the problem

1. Create a Marker on the map and click on it to open its info window
2. With the info window open, remove that Marker from the map and redraw the map (for example, as the result of a search that is only showing a subset of all markers)
3. The Marker is removed but the info window remains open and visible

I tried overriding several onRemove type methods to no avail, although this should really be the default behavior. A workaround that we have in place is to close all open info windows when the map overlays are updated, but this shouldn’t be necessary.

FWIW, we are overriding onMarkerClickListener (to avoid the default map recentering that accompanies the info window being opened), but I don’t see why that would cause this problem.

Environment

Latest version of osmdroid, Android SDK 33, testing in the Android emulator.

If it’s a bug, version(s) of android this affects:

Not sure. Only tested on one so far.

Version of osmdroid the issue relates to:

6.1.2

Thanks for all the hard work on osmdroid! This is a really great library.

[MKergall]

It is not based on use cases - it’s a drawback of the implementation method. And it’s clearly an issue. InfoWindow.closeAllInfoWindowsOn is just an awful workaround. But I also know that it’s clearly “extra work” to achieve the non-strange result.

Have a look at #397 :
“Marker should have a factory-method to create an InfoWindow on demand instead of containing a precreated InfoWindow . The object “InfoWindow” should only exist as long as the popup-bubble is opend.”

By the way, this is not specific to Marker, but to all OverlayWithIW.

Ideas and PRs are welcomed, but keep in mind that a rework on this class may have serious impacts on users who implemented subclasses of Markers, made customized infowindows, etc.

[gchallen]

Yes, strange, but it is doable!

Sure, but what’s strange shouldn’t be the default behavior 😄. I think it’s reasonable to expect that the popup is removed with the marker. If you want to change that behavior for some strange reason, then having a way to disable that would be fine. But ideally it shouldn’t be extra work to achieve the non-strange result.