Duplicated code in PackitAPI.run_copr_build() & packit-service/copr_build.py

With https://github.com/packit-service/packit-service/pull/547 we duplicate PackitAPI.run_copr_build() content also in packit_service’s CoprBuildJobHelper.run_build(). The reason is that the method in PackitAPI builds SRPM as a first thing (which we don’t want to do in CoprBuildJobHelper.run_build()).

Can we either?:

• Change PackitAPI.run_copr_build() so that it does not call PackitAPI.create_srpm(), but accepts srpm path (so the caller has to call create_srpm() themselves first). I know this changes the API (hey, is there any other API consumer besides us?), but what about taking it as an opportunity to release packit 1.0.0? 😃
• Move all but the PackitAPI.create_srpm() call from PackitAPI.run_copr_build() to separate method which then PackitAPI.run_copr_build() and the CoprBuildJobHelper.run_build() could call.

[csomh]

I think we discussed something similar during the arch-meetings, but that might have been about splitting the task in Packit Service to SRPM build and build.

In any case, I’m for looking into something like this.

• Change PackitAPI.run_copr_build() so that it does not call PackitAPI.create_srpm(), but accepts srpm path (so the caller has to call create_srpm() themselves first). I know this changes the API (hey, is there any other API consumer besides us?), but what about taking it as an opportunity to release packit 1.0.0? 😃

This seems to be the cleanest option.

Could we have PackitAPI.run_build(srpm_path) and deprecate run_copr_build() sometime in the future? Is the build service configurable in Packit?

[jpopelka]

I’ve been looking at this (aiming to implement https://github.com/packit/packit/issues/831#issuecomment-631011749) and the CoprBuildJobHelper.run_build() now does much more than just srpm build + PackitAPI.run_copr_build(). There’s lots of try: except: and I don’t see how to call PackitAPI.run_copr_build() from CoprBuildJobHelper.run_build() now. As a reporter I’m closing this explicitly.