packit action create-archive / fix-spec-file

Hi,

I’m hitting an interesting issue with packit actions. I wrote simple action to create a tarball.

15:55:44.931 utils.py          DEBUG  STDOUT: restraint-0.1.41-1-5-g7889493
15:55:44.931 upstream.py       DEBUG  version = restraint-0.1.41-1-5-g7889493
15:55:44.931 upstream.py       DEBUG  sanitized version = restraint.0.1.41.1.5.g7889493
15:55:44.935 upstream.py       DEBUG  name + version = restraint-restraint.0.1.41.1.5.g7889493
Using user-defined script for ActionName.create_archive: ['make', 'packit-tgz']
15:55:44.935 utils.py          DEBUG  cmd = 'make packit-tgz'
15:55:45.582 utils.py          DEBUG  STDOUT: SRPM=$(tito build --tgz --test -o . | tail -1 | awk -F'/' '{print $NF}'); \
echo $SRPM
restraint-git-5.7889493.tar.gz
15:55:45.582 base_git.py       DEBUG  Action command output: ["SRPM=$(tito build --tgz --test -o . | tail -1 | awk -F'/' '{print $NF}'); \\\necho $SRPM\nrestraint-git-5.7889493.tar.gz\n"]
Created archive: restraint-git-5.7889493.tar.gz

Docs says is expected to return the created archive name. If there are more steps, then one of them has to return the archive name. Checked!

I don’t have create-patches - default. I don’t have fix-spec-file - default. Exec fix_spec

15:55:45.583 base_git.py       DEBUG  Running default implementation for ActionName.fix_spec.
14:55:45.716 upstream.py       DEBUG  new %setup line:
%setup -q -n restraint-restraint.0.1.41.1.5.g7889493
14:55:45.923 upstream.py       DEBUG  present srpms = {PosixPath('/home/mastyk/work/github.com/StykMartin/restraint/restraint-restraint.0.1.41.1.5.g7889493-1.fc31.src.rpm')}
14:55:45.924 utils.py          DEBUG  cmd = 'rpmbuild -bs --define _sourcedir . --define _specdir /home/mastyk/work/github.com/StykMartin/restraint --define _srcrpmdir /home/mastyk/work/github.com/StykMartin/restraint --define _topdir /home/mastyk/work/github.com/StykMartin/restraint --define _builddir /home/mastyk/work/github.com/StykMartin/restraint --define _rpmdir /home/mastyk/work/github.com/StykMartin/restraint --define _buildrootdir /home/mastyk/work/github.com/StykMartin/restraint restraint.spec'

Accordingly to fix-spec-file docs first step should be Replaces Source0 with a local path to the generated tarball. Well, name of my tarball is different and I reported it. Is this behavior intended?

Regards, Martin

[lachmanfrantisek]

I am sorry, but I am really not sure about the outcome of this issue.

I’m going to close the issue, but if you feel something is missing on our site, please don’t be afraid to reopen or (ideally) create a new issue with the more specific request. Thanks in advance!

[jpopelka]

@StykMartin @TomasTomecek did we discuss this last week? Can you remind me the resolution?