packit srpm ignores actions

I’m currently testing packit for cockpit-podman, to move away from the cockpituous rpm/Fedora scripts. I did a first naïve branch which just adds a packit.yaml.

I tried to build an srpm:

$ git clone -b packit https://github.com/martinpitt/cockpit-podman
$ cd cockpit-podman
$ packit srpm
ERROR    
Unexpected exception occurred,
please fill an issue here:
https://github.com/packit-service/packit/issues

This is due to cockpit-podman.spec not existing. The error message is unhelpful, but that’s issue #290. The point here is that packit.yaml has an action to build the spec:

actions:
  prepare-files: make cockpit-podman.spec
  create-archive: make dist-gzip

but this doesn’t seem to get run – there is no cockpit-podman.spec in the tree after the failing command. I also tried pre-sync:, that doesn’t work either.

After manually running make cockpit-podman.spec, packit srpm stops crashing and builds an srpm, but it generates a default tarball, instead of using make dist-gzip.

So it seems the srpm command generally ignores actions?

packit-0.2.0-1.fc31.noarch

[martinpitt]

Let’s discuss the changelog bits in issue #298, to keep it in one place.

Possibly it could be done with a hook, but I think implementing a sane default behaviour in packit would be better than replicating the same hook across most/all packit.yaml files out there.

[lachmanfrantisek]

But that’s the wrong place – it needs to happen in packit propose-update

The post-upstream-clone is used in the propose-update as well.

If I got you correctly:

• For propose-update, you cannot update an upstream version and copy the content to the distgit.
• For srpm, the upstream specfile is ok.

Would it help to add a new hook to propose-update after the sync and before the distgit commit? (Run from the distgit directory.)