Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

resolvedTheme can be `system`

See original GitHub issue

I have noticed in testing that useTheme().resolvedTheme can be system. I think it’s only happening in the first render, but I haven’t tried making a minimal reproduction.

I am using next-themes@npm:0.0.13-beta.2 [9e7cc] (via npm:beta [9e7cc]) and not passing any options to <ThemeProvider>.

Is this expected behavior?

Issue Analytics

State:
Created 3 years ago
Comments:8 (2 by maintainers)

Top GitHub Comments

2reactions

pacocourseycommented, Mar 17, 2021

Sweet, thanks! I wasn’t able to reproduce the issue on the first render, but I was able to reproduce the issue when doing setTheme('system') twice.

@thien-do explained it in #34

since the theme value (in state) is not changed (still “system”), the “handleMediaQuery” is not triggered

I updated the logic in this commit: https://github.com/pacocoursey/next-themes/pull/30/commits/8ab93d96b771cd4a523688d2cc6abce2386dada3

Basically when setting theme to system, it wasn’t applying the resolved theme – that only happened by accident! This adds the check and actually makes it faster (previously there were two calls: one to update the DOM to system, then another to update the DOM to dark/light)

0reactions

thien-docommented, Mar 18, 2021

You rock @pacocoursey 🚀 it’s fixed!