pact-node throws promise rejection errors

Software versions

• OS: Mac OSX 10.13.6
• Library version: @pact-foundation/pact-node@6.20.0
• Node Version: v8.11.0

Expected behaviour

Using pact-node shouldn’t affect the behaviour of unhandled promise rejections.

Actual behaviour

When pact-node is included in a project, any unhandled promise rejections result in the following error:

/Users/work/office/pact/example/node_modules/@pact-foundation/pact-node/standalone/install.js:263
    throw new Error(chalk.red("Unhandled Promise Rejection: " + e));
    ^

Error: Unhandled Promise Rejection: Boom
    at process.<anonymous> (/Users/work/office/pact/example/node_modules/@pact-foundation/pact-node/standalone/install.js:263:11)
    at emitTwo (events.js:126:13)
    at process.emit (events.js:214:7)
    at emitPendingUnhandledRejections (internal/process/promises.js:108:22)
    at process._tickCallback (internal/process/next_tick.js:189:7)

This is a problem, because it prevents the development of APIs that return rejecting promises, and also it is swallowing any supporting information about where the rejection came from.

It’s especially a problem if the test setup script requires pact, as then any unhandled rejections anywhere in the code will fail.

Steps to reproduce

Clone this repository:

https://github.com/TimothyJones/pact-node-rejection-issue

Then:

npm install && npm run test

Relevant log files

None, but the error comes from this line:

https://github.com/pact-foundation/pact-node/blob/master/standalone/install.ts#L309

I’m not sure why the handler exists - can anyone shed any light?

[mboudreau]

I’m sorry everyone for causing this issue, it was a refactor that I didn’t properly think through. I’ve now removed the global promise rejection handler and instead just wrapped the promise rejection with a function that handles it. Fix is available in version 6.20.2. Cheers.

[mefellows]

Thanks for fixing Michel!