question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

participantVersion and latest are not mutually exclusive in CanDeploy

See original GitHub issue

Hello friends, I’m happy to use Pact!

I’ve noticed something in how pact-node parses the options to can-i-deploy.

Software versions

Expected behavior

I think pact can-i-deploy command and CanDeploy should allow me to check whether I can deploy current service against the specified tag without specifying a version.

Actual behavior

I’m using the Broker credentials from Pact Workshop to illustrate this:

npx pact can-i-deploy
        --participant 'Our Provider' \
        --latest prod \
        --pact-broker https://test.pact.dius.com.au \
        --username dXfltyFMgNOFZAxr8io9wJ37iUpY42M \
        --password O5AIZWxelWbLvqMd8PkAVycBJh2Psyg1

Error: Missing option --participant-version.

I might be wrong, but I think this is incorrect behavior. 🤔

These checks https://github.com/pact-foundation/pact-node/blob/master/src/can-deploy.ts#L50 should be checking if latest is specified and not require participantVersion in that case.

I can work on the PR to change this.

What do you think?

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:8 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
TimothyJonescommented, Oct 28, 2019

This is released in pact-node 10.0.0, which is a breaking change to the way options work. See the changelog for more details

0reactions
halfzebracommented, Oct 28, 2019

Thanks for the update!

Read more comments on GitHub >

github_iconTop Results From Across the Web

Cadeploy
Cadeploy are specialize in pre engineered metal building, tekla structures, Reinforced Concrete, Precast Concrete, rebar detailing and much more.
Read more >
JP 3-22, Foreign Internal Defense, 17 August 2018
Similar to an IDAD, “Plan Colombia” was not exclusively a military or security strategy, but it was an inclusive plan that spanned the....
Read more >
Untitled
Non legislative acts european union, Dream theater summer sonic, Maniva passo, ... The gaslight anthem 59 sound guitar tab, Putih bersamamu new version, ......
Read more >
JP 3-22, Foreign Internal Defense
For doctrine and procedures not ratified by the United States, ... Foreign internal defense (FID) is the participation by.
Read more >
March 2020
Opinions are those of the writers and AISC is not responsible for any ... current version and are available at aisc.org/publications. Modern.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found