Pending Pacts - pactbroker.providerBranches not working

I tried using pactbroker.providerBranches (replacing pactbroker.providerTags) on my provider with latest release 4.3.8. It is not able to fetch pending and wip pacts using branches. It was able to fetch the pending and wip pacts using tags. Doing bit of investigation, it appears the problem is because this code populates providerVersionBranches but Pact broker expects providerVersionBranch I think (@bethesque ?). This is my suspect but I am not sure.

Pactbroker log:

2022-05-26 17:48:01.586098 I [7:puma srv tp 001] PactBroker::Api::Resources::ProviderPactsForVerification -- Fetching pacts for verification by pactdemo-provider-springboot -- {:provider_name=>"pactdemo-provider-springboot", :params=>{"consumerVersionSelectors"=>[{"mainBranch"=>true}, {"deployedOrReleased"=>true}], "includePendingStatus"=>true, "includeWipPactsSince"=>"2022-05-01", "providerVersionBranches"=>["mybranch"], "providerVersionTags"=>[]}}

[praveen-em]

sure, I will give it a shot.

[YOU54F]

Hi,

I think you are correct

https://github.com/pact-foundation/pact-ruby/blob/f0e37a4794e72d0a469298ff592d69f1304c9022/lib/pact/pact_broker/fetch_pact_uris_for_verification.rb#L82-L83

providerVersionBranches refs only exist in pact-jvm

https://github.com/search?q=providerVersionBranches&type=code

providerVersionBranch refs exist in several locataions (docs and source)

https://github.com/search?q=providerVersionBranch&type=code

Also looking at the code, it’s expecting a single value string not an array

Would happily accept a pull request if you have time?