Changes introduced to string quoting in responses

First of all, thank you for maintaining this wonderful project!

We’ve been running CI tests on our product that uses click, and tests for command-line stumbled upon a change in output representation introduced in “manual cleanup” commit.

I do not see this as an issue in click, but it took some time to find the origin, and so I suggest to mention effects of this change in documentation or changelog.

Thank you!

---

Expected Behavior

Previously a missing option string was displayed with double-quotes:

Error: Missing option "--os".

Actual Behavior

Now a missing option string is displayed with single-quotes, as per repr() implementation:

Error: Missing option '--os'.

Environment

• Python version: 3.8
• Click version: 7.1.1

[davidism]

This was intentional to make quoting consistent both across Click error messages and with the quoting used in Python error messages. Sorry for the confusion, I didn’t consider that it would be difficult to spot the difference in tests that look for exact matches. I don’t plan to revert it, but I can add a mention to the changelog, even though it’s a bit old at this point.

[WhyNotHugo]

Thanks!

– Hugo Osvaldo Barrera

On 2020-06-11, at 18:48, David Lord [e-mail] wrote:

Closed #1499.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.