Add name and filename to Environment.from_string

What do you think about add name and filename parameters in Environment.from_string method ? https://github.com/pallets/jinja/blob/master/jinja2/environment.py#L849

Something like that:

    def from_string(self, source, name=None, filename=None, globals=None, template_class=None):
        """Load a template from a string.  This parses the source given and
        returns a :class:`Template` object.
        """
        globals = self.make_globals(globals)
        cls = template_class or self.template_class
        return cls.from_code(self, self.compile(source, name=name, filename=filename), globals, None)

Best regards, Stéphane

[mitsuhiko]

Correct, that will work.

[guilhem-]

Right. Even if providing two times the same information to a component may sound as unoptimal from a caller point of view, I can understand other reasons exist not to do it from a callee perspective…

Finally using Ansible, it appeared to be as simple as the following code to transfer the file name information into the template…

template: src: ‘{{ src_dir }}’ dest: ‘{{ dst_dir }}’ vars: file_path: “{{item.path}}” with_filetree: templates/xyz