CI: Linting errors from flake >= 3.8.1
See original GitHub issueThe new version of flake bumps the version of pycodestyle, which results in several linting errors on CI. These include:
- (many instances) E741:ambiguous variable name ‘l’
- (many instances) F541:f-string is missing placeholders
- (one or few instances) E721:do not compare types, use ‘isinstance()’
Here the output:
2020-05-13T05:37:20.8820311Z ##[error]./pandas/_testing.py:630:22:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8824860Z ##[error]./pandas/_testing.py:1006:17:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8825837Z ##[error]./pandas/core/indexing.py:1569:42:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8826437Z ##[error]./pandas/core/series.py:2588:17:F541:f-string is missing placeholders
2020-05-13T05:37:20.8826992Z ##[error]./pandas/core/common.py:40:13:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8827546Z ##[error]./pandas/core/common.py:280:20:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8828505Z ##[error]./pandas/core/common.py:288:24:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8829122Z ##[error]./pandas/core/frame.py:685:37:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8830045Z ##[error]./pandas/core/indexes/multi.py:992:49:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8830652Z ##[error]./pandas/core/indexes/multi.py:1143:15:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8831243Z ##[error]./pandas/core/indexes/multi.py:1146:29:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8831817Z ##[error]./pandas/core/reshape/reshape.py:143:37:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8832381Z ##[error]./pandas/core/dtypes/concat.py:27:21:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8832963Z ##[error]./pandas/core/internals/concat.py:446:28:E721:do not compare types, use 'isinstance()'
2020-05-13T05:37:20.8833301Z ##[error]./pandas/core/arrays/interval.py:1054:5:E301:expected 1 blank line, found 0
2020-05-13T05:37:20.8833868Z ##[error]./pandas/util/_doctools.py:37:52:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8834428Z ##[error]./pandas/util/_doctools.py:38:48:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8834986Z ##[error]./pandas/util/_doctools.py:40:49:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8835554Z ##[error]./pandas/util/_doctools.py:41:49:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8836113Z ##[error]./pandas/util/_doctools.py:61:35:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8837945Z ##[error]./pandas/util/_doctools.py:76:55:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8838579Z ##[error]./pandas/util/_doctools.py:77:55:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8839206Z ##[error]./pandas/util/_doctools.py:91:17:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8839782Z ##[error]./pandas/plotting/_matplotlib/tools.py:374:9:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8840359Z ##[error]./pandas/plotting/_matplotlib/boxplot.py:147:29:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8840933Z ##[error]./pandas/plotting/_matplotlib/boxplot.py:148:43:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8842322Z ##[error]./pandas/plotting/_matplotlib/core.py:1508:56:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8843347Z ##[error]./pandas/io/pytables.py:4587:59:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8844029Z ##[error]./pandas/io/parsers.py:2971:13:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8845476Z ##[error]./pandas/io/parsers.py:3000:13:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8846243Z ##[error]./pandas/io/parsers.py:3020:13:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8847558Z ##[error]./pandas/io/formats/format.py:979:57:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8848615Z ##[error]./pandas/tests/groupby/test_categorical.py:505:13:F541:f-string is missing placeholders
2020-05-13T05:37:20.8849732Z ##[error]./pandas/tests/groupby/transform/test_numba.py:20:46:F541:f-string is missing placeholders
2020-05-13T05:37:20.8850374Z ##[error]./pandas/tests/groupby/transform/test_numba.py:23:46:F541:f-string is missing placeholders
2020-05-13T05:37:20.8851580Z ##[error]./pandas/tests/groupby/aggregate/test_numba.py:21:46:F541:f-string is missing placeholders
2020-05-13T05:37:20.8852714Z ##[error]./pandas/tests/groupby/aggregate/test_numba.py:24:46:F541:f-string is missing placeholders
2020-05-13T05:37:20.8853337Z ##[error]./pandas/tests/indexes/interval/test_interval.py:56:43:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8853951Z ##[error]./pandas/tests/indexes/interval/test_interval.py:77:17:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8854548Z ##[error]./pandas/tests/indexes/interval/test_constructors.py:333:17:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8855131Z ##[error]./pandas/tests/indexes/multi/test_indexing.py:797:13:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8855712Z ##[error]./pandas/tests/plotting/test_datetimelike.py:760:13:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8856293Z ##[error]./pandas/tests/plotting/test_datetimelike.py:787:13:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8856877Z ##[error]./pandas/tests/plotting/test_datetimelike.py:800:13:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8857459Z ##[error]./pandas/tests/plotting/test_datetimelike.py:866:13:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8858037Z ##[error]./pandas/tests/plotting/test_datetimelike.py:884:13:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8858611Z ##[error]./pandas/tests/plotting/test_datetimelike.py:997:13:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8859187Z ##[error]./pandas/tests/plotting/test_datetimelike.py:1006:13:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8859765Z ##[error]./pandas/tests/plotting/test_datetimelike.py:1131:13:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8860363Z ##[error]./pandas/tests/plotting/test_datetimelike.py:1135:13:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8860937Z ##[error]./pandas/tests/plotting/test_datetimelike.py:1236:13:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8861515Z ##[error]./pandas/tests/frame/methods/test_to_dict.py:121:13:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8862087Z ##[error]./pandas/tests/reshape/test_pivot.py:2069:17:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8862677Z ##[error]./pandas/tests/reshape/merge/test_merge.py:2183:38:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8863272Z ##[error]./pandas/tests/reshape/merge/test_merge.py:2183:69:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8863847Z ##[error]./pandas/tests/io/test_stata.py:1864:35:F541:f-string is missing placeholders
2020-05-13T05:37:20.8864409Z ##[error]./pandas/tests/io/test_sql.py:2402:13:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8864972Z ##[error]./pandas/tests/io/test_sql.py:2683:13:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8865545Z ##[error]./pandas/tests/io/formats/test_format.py:1801:31:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8866121Z ##[error]./pandas/tests/extension/test_interval.py:30:32:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8866713Z ##[error]./pandas/tests/indexing/test_floats.py:287:50:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8867287Z ##[error]./pandas/tests/indexing/test_floats.py:346:17:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8867867Z ##[error]./pandas/tests/indexing/test_floats.py:360:17:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8868581Z ##[error]./pandas/tests/indexing/test_floats.py:383:17:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8869229Z ##[error]./pandas/tests/indexing/test_floats.py:407:48:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8869822Z ##[error]./pandas/tests/indexing/test_floats.py:439:13:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8870388Z ##[error]./pandas/tests/indexing/test_floats.py:455:13:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8870956Z ##[error]./pandas/tests/indexing/test_floats.py:470:13:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8871524Z ##[error]./pandas/tests/indexing/test_floats.py:492:66:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8872091Z ##[error]./pandas/tests/indexing/test_floats.py:519:32:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8872862Z ##[error]./pandas/tests/indexing/test_loc.py:802:22:E741:ambiguous variable name 'l'
2020-05-13T05:37:20.8873460Z ##[error]./asv_bench/benchmarks/reshape.py:106:36:E741:ambiguous variable name 'l'
There is an additional issue with flake8-rst, e.g. here:
Happy to have a go, but would like suggestions about how to proceed? Suggestion:
Staged approach:
- Pin flake < 3.8.0 to deal with flake8-rst issue
- Ignore errors to get build green
- Address F541
- Address E721
- Address E741 (or not?)
Issue Analytics
- State:
- Created 3 years ago
- Comments:8 (4 by maintainers)
Top Results From Across the Web
GitHub actions flake8 Lint failing upon commit "failed with exit ...
Your issue appears to be that your code doesn't pass PEP8, which the Flake8 check will fail if you don't (that's the point...
Read more >flake8 Documentation - Read the Docs
The project Flake8 depends on to lint files (check for unused imports, variables, etc.). This uses the F class of error codes reported...
Read more >Flake8: Your Tool For Style Guide Enforcement — flake8 6.0.0 ...
This provides examples and documentation around Flake8's assortment of options and how to specify them on the command-line or in configuration files. Using...
Read more >Hypermodern Python 3: Linting - Medium
Linting with Flake8 Linters analyze source code to flag programming errors, bugs, stylistic errors, and suspicious constructs. The most common ...
Read more >Flake8 - PyPI
Project description. build status pre-commit.ci status Discord ... you can ignore specific errors on a line with # noqa: <error>, e.g., # noqa:...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Indeed. Though I believe, I have solved the kataev/flake8-rst#22 in https://github.com/kataev/flake8-rst/pull/23.
for now i would simply fix the version of flake ❤️.8 until we can address things