ENH: Tox as main entry point for development

So I have been working on issue #23154 trying to setup flake8-rst as additional check for code within documentation.

It’s working great, finding multiple places to fix, however in order to test I’m not able to run the appropriate commands.

• created a conda environment
• installed dependencies from ./ci/requirements_dev.txt and ./ci/requirements-optional-conda.txt
• activated pandas-dev environment
• executed python make.py html within ./doc folder

Resulting in

~/.../pandas/core/algorithms.py in _factorize_array(values, na_sentinel, size_hint, na_value)
    472     table = hash_klass(size_hint or len(values))
    473     labels, uniques = table.factorize(values, na_sentinel=na_sentinel,
--> 474                                       na_value=na_value)
    475 
    476     labels = ensure_platform_int(labels)

TypeError: factorize() takes no keyword arguments

So I can’t really evaluate weather the changes I am going to make are correct.

Trying to build pandas or running the test suite never worked for me as well. Maybe it’s just my own error, but I think there are others getting these issues.

As the project is already featuring tox I’m proposing to enhance tox with all these use-cases so that after a fresh clone of the project someone can just type tox -e docs and tox creates a venv with all required dependencies and runs the build, tox -e check to run flake8, isort, validate_docstrings.py … tox for a complete check of everything -> reducing failing ci-builds

In my opinion this could simplify someones first steps to contribute to pandas. What do you think?

[TomAugspurger]

That’s a bug with IPython 7.0. It’s fixed on IPython master.

[jorisvandenbossche]

@FHaase regarding the error you get: you need to (re)build the pandas C extensions (python setup.py build_ext --inplace)