read_excel does not raise error with wrong keyword arg

For example:

pd.read_excel('file_name.xlsx',sheet='mysheet')

does not raise any error. The right parameter name is “sheetname” . If “sheet” is passed it defaults to the first sheet and no error is raised.

sheetname and sheet are very similar and easy to confuse.

One might think that it is reading the sheet passed as argument when in fact it is another one.

I would like to suggest for errors to be raised if unexpected args are passed.

[joonro]

+1. I just got bitten by sheet_name.

[TomAugspurger]

I think the goal is to remove the **kwargs from the signature. Then we don’t have to worry about validating unknown parameters.

On Fri, May 25, 2018 at 8:50 AM, Luciano Viola [e-mail] wrote:

Hey guys, I’m having a bit of difficulty figuring out how to solve this one. I’m new to open source contributing, but I’m really excited about it.

My initial solution was to raise a warning if “sheet” was in kwargs, it does not generalize to things like “Sheet”.

So, in my view, we either list all possible misspellings and and confusion possibilities of sheetname and check directly check it they where passed, or we review the need to have kwargs.

I don’t think that words like "Sheet’ are such a problem, I don’t think its a very common mistake. The one I’m concerned about is “sheet”.

What do you guys think? =)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pandas-dev/pandas/issues/17994#issuecomment-392064067, or mute the thread https://github.com/notifications/unsubscribe-auth/ABQHInNXhjgshmcamekAWgLFLrFX_H0bks5t2Aw8gaJpZM4QH-GS .