question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Remove `-Werror` from setup.py

See original GitHub issue

It seems nice to have -Werror in CI but as a conda-forge maintainer I quite often have to write patches to remove -Werror from releases as the system distributions build packages on are not identical to the ones CI of upstream runs on. There is a large variety of compiler warnings and some may only show up when other C-defines are set. Also many new warning appear when you build with a newer compiler or different versions of the dependencies used.

My suggestion would be:

  • Remove -Werror from setup.py.
  • Add -Werror to CFLAGS on CI to have the same result for pandas-dev as it is currently.

Original PR: https://github.com/pandas-dev/pandas/pull/32163

Related issues: https://github.com/pandas-dev/pandas/issues/33314, https://github.com/pandas-dev/pandas/issues/33224

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:1
  • Comments:26 (25 by maintainers)

github_iconTop GitHub Comments

1reaction
mgornycommented, Jul 29, 2020

There’s also a bunch of new deprecations in Python 3.9: _PyUnicode_get_wstr_length, PyUnicode_AsUnicode

0reactions
xhochycommented, Nov 26, 2020

@xhochy would u push a PR to remove the flag but keep on CI; would do for 1.2 and 1.1.5

Already on it this minute!

Read more comments on GitHub >

github_iconTop Results From Across the Web

python setup.py uninstall - Stack Overflow
Here is the proof. [sri@localhost python]$ pip uninstall foo DEPRECATION: Uninstalling a distutils installed project (foo) has been deprecated ...
Read more >
Command python setup py egg info failed with error code 1 in ...
Hi Guys, I am trying to install jupyter in my Windows system, but It shows me the below error ... \AppData\Local\Temp\ How can...
Read more >
3. Configure Python — Python 3.11.1 documentation
Configure Options: List all./configure script options using: See also the Misc/SpecialBuilds.txt in the Python source distribution.
Read more >
PipProblems - FlexGet
Solution in the forum was to remove pip from OS package manager. And the follow this. ¶ Default python version switched. [root@foobar ~]#...
Read more >
Nupic Installation on MacOS(12.0) error - HTM Forum - Numenta
RuntimeError: support for python < 3.6 has been removed in ... 2 make: *** [all] Error 2 Traceback (most recent call last): File...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found