question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

STYLE: upgrade flake8

See original GitHub issue

Issue here is:

  1. checkout the create-pr-action/pre-commit-config-update-0 branch
  2. run pre-commit run flake8 --all-files. You should see some errors like:
pandas/tests/indexes/categorical/test_formats.py:24:89: E501 line too long (98 > 88 characters)
pandas/tests/indexes/categorical/test_formats.py:55:89: E501 line too long (98 > 88 characters)
pandas/tests/indexes/categorical/test_formats.py:89:89: E501 line too long (90 > 88 characters)
pandas/tests/frame/test_query_eval.py:917:17: B020 Found for loop that reassigns the iterable it is iterating with each iterable value.
pandas/tests/frame/test_query_eval.py:917:26: B020 Found for loop that reassigns the iterable it is iterating with each iterable value.
pandas/tests/frame/test_query_eval.py:958:17: B020 Found for loop that reassigns the iterable it is iterating with each iterable value.
pandas/tests/frame/test_query_eval.py:958:26: B020 Found for loop that reassigns the iterable it is iterating with each iterable value.
pandas/core/strings/object_array.py:375:69: B023 Function definition does not bind loop variable 'pat'.
pandas/tests/window/test_rolling.py:819:10: B020 Found for loop that reassigns the iterable it is iterating with each iterable value.
pandas/tests/window/test_rolling.py:867:10: B020 Found for loop that reassigns the iterable it is iterating with each iterable value.
pandas/tests/window/test_rolling.py:917:10: B020 Found for loop that reassigns the iterable it is iterating with each iterable value.
pandas/tests/window/test_rolling.py:969:10: B020 Found for loop that reassigns the iterable it is iterating with each iterable value.
pandas/tests/io/parser/test_c_parser_only.py:194:49: B023 Function definition does not bind loop variable 'actual_val'.
pandas/tests/window/test_expanding.py:221:10: B020 Found for loop that reassigns the iterable it is iterating with each iterable value.
pandas/tests/window/test_expanding.py:240:10: B020 Found for loop that reassigns the iterable it is iterating with each iterable value.
pandas/tests/arrays/categorical/test_repr.py:321:89: E501 line too long (97 > 88 characters)
pandas/tests/arrays/categorical/test_repr.py:354:89: E501 line too long (97 > 88 characters)
pandas/io/formats/excel.py:175:6: B019 Use of `functools.lru_cache` or `functools.cache` on methods can lead to memory leaks. The cache may retain instance references, preventing garbage collection.
pandas/tests/arrays/masked/test_arithmetic.py:58:9: B020 Found for loop that reassigns the iterable it is iterating with each iterable value.
pandas/tests/arrays/masked/test_arithmetic.py:217:9: B020 Found for loop that reassigns the iterable it is iterating with each iterable value.
pandas/tests/groupby/transform/test_transform.py:760:9: B020 Found for loop that reassigns the iterable it is iterating with each iterable value.
pandas/tests/indexes/multi/test_formats.py:186:89: E501 line too long (95 > 88 characters)
scripts/no_bool_in_generic.py:42:21: B020 Found for loop that reassigns the iterable it is iterating with each iterable value.
pandas/tests/io/sas/test_sas7bdat.py:323:17: B020 Found for loop that reassigns the iterable it is iterating with each iterable value.
pandas/io/pytables.py:4131:38: B023 Function definition does not bind loop variable 'obj'.
pandas/io/pytables.py:4[132](https://github.com/pandas-dev/pandas/runs/7809209712?check_suite_focus=true#step:4:134):39: B023 Function definition does not bind loop variable 'obj'.
pandas/io/pytables.py:4133:39: B023 Function definition does not bind loop variable 'obj'.
pandas/io/pytables.py:4144:38: B023 Function definition does not bind loop variable 'op'.
pandas/io/pytables.py:4145:36: B023 Function definition does not bind loop variable 'obj'.
pandas/io/pytables.py:4151:59: B023 Function definition does not bind loop variable 'obj'.
pandas/io/pytables.py:4155:43: B023 Function definition does not bind loop variable 'obj'.
pandas/io/pytables.py:4157:38: B023 Function definition does not bind loop variable 'op'.
pandas/io/pytables.py:4158:36: B023 Function definition does not bind loop variable 'obj'.
  1. Fixup these errors, and when pre-commit run flake8 --all-files passes, stage, commit, and push!

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
MarcoGorellicommented, Aug 13, 2022

Could we just ignore them for now, so we can get the upgraded versions, and have a todo or an issue about enabling them?

0reactions
jmoro0408commented, Aug 13, 2022

Yep that definitely makes more sense, thanks! I’ll try to get to this today.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Flake8: Your Tool For Style Guide Enforcement — flake8 6.0.0 ...
It is very important to install Flake8 on the correct version of Python for your needs. If you want Flake8 to properly parse...
Read more >
flake8-import-style - PyPI
A flake8 plugin to ensure explicit module imports. For more information, see github.com/sfstpala/flake8-import-style.
Read more >
PyCQA/flake8 - GitHub
flake8 is a python tool that glues together pycodestyle, pyflakes, mccabe, and third-party plugins to check the style and quality of some python...
Read more >
How to Use Flake8 - Simple is Better Than Complex
Flake8 is a Python library that wraps PyFlakes, pycodestyle and Ned ... toolkit for checking your code base against coding style (PEP8), ...
Read more >
Flake8 — Firefox Source Docs documentation - Mozilla
Flake8 is a popular lint wrapper for python. ... pep8 for checking style ... Please update this file rather than tools/lint/flake8.yml if you...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found