Drawer does not work with FragNav

I’m using FragNav for fragments navigation (https://github.com/ncapdevi/FragNav) and when i set up MainActivity like this:

@AndroidEntryPoint
class MainActivity : AppCompatActivity(), FragNavController.TransactionListener {
    private val binding by viewBinding(ActivityMainBinding::inflate)

    val fragNavController = FragNavController(supportFragmentManager, R.id.fragmentContainer)

    override fun onCreate(savedInstanceState: Bundle?) {
        setTheme(R.style.AppTheme)
        super.onCreate(savedInstanceState)
        setContentView(binding.root)

        fragNavController.apply {
            transactionListener = this@MainActivity
            rootFragments = listOf(HomeFragment())
            fragNavLogger = object : FragNavLogger {
                override fun error(message: String, throwable: Throwable) {
                    Timber.e(throwable, message)
                }
            }

            defaultTransactionOptions = FragNavTransactionOptions.newBuilder().customAnimations(
                R.anim.slide_left_from_right,
                R.anim.slide_left_from_middle,
                R.anim.slide_right_from_left,
                R.anim.slide_right_from_middle
            ).build()
            initialize(savedInstanceState = savedInstanceState)
        }
    }
}

the Beagle.show() returns false. When i inspect layout - no overlay is being added. If i disable FragNav like this:

@AndroidEntryPoint
class MainActivity : AppCompatActivity() {
    private val binding by viewBinding(ActivityMainBinding::inflate)

    override fun onCreate(savedInstanceState: Bundle?) {
        setTheme(R.style.AppTheme)
        super.onCreate(savedInstanceState)
        setContentView(binding.root)

        supportFragmentManager.commit {
            replace(R.id.fragmentContainer, HomeFragment())
        }
    }
}

It works perfectly. FragNav is pretty important to me. Is there a way to bypass this issue?

[pandulapeter]

Awesome 👍 And thanks for posting the code as well.

Yeah, the OverlayFragment does a couple of things: while you’re right that its View hierarchy is only used for the Drawer, it also handles some Activity Results (screenshot, screen recording) and the keyline overlay module which must work for all types, so it must be added.

I’ll close this one for now, I think this is a reasonable workaround and a more elegant solution would be the ability to whitelist some Fragment tags in FragNav which doesn’t depend on us. Thanks for bringing it up, let me know if you find anything else!

[pandulapeter]

Hi,

Thanks for the bug report, this sounds interesting! I’ve never used FragNav so I’m investigating this right now (I’ve managed to reproduce the issue). Should be something simple, as apparently this addOverlayFragment() function fails to do its job, my first guess was that FragNav is replacing the Fragment in the android.R.id.content FrameLayout with something else but looks like that’s not the case. Anyway, I’ll let you know when I find something.