DPLE_hindcast_prediction comments
See original GitHub issueThis package looked interesting so I started playing with the DPLE_hindcast_prediction notebook, and I just wanted to leave a few comments.
-
CESM DPLE; I know about CESM, but I’m unfamiliar with DPLE and it wasn’t until midway I encountered the title
Decadal Prediction Large Ensemble
. So I think it might be good to define the acronyms on the first encounter, e.g.What are we comparing the actual Decadal Prediction Large Ensemble (DPLE) to?
-
The name of the notebook doesn’t match the first markdown cell:
DPLE_hindcast_prediction
vsReconstruction-based Prediction Demo
which I thought to be slightly confusing. -
I think because proplot is in its development stage, there were keywords that were changed (probably related to https://github.com/bradyrx/climpred/issues/88). One example:
f, ax = plot.subplots(axwidth=4, aspect=1, rightpanel=True)
TypeError: _subplots_kwargs() got an unexpected keyword argument 'rightpanel'
Anyways, I think this is a great effort; I’m still trying to grasp it all, but I would love to contribute eventually! (Maybe a quick start guide would be helpful too!)
Issue Analytics
- State:
- Created 4 years ago
- Comments:7 (2 by maintainers)
Top GitHub Comments
Your object-oriented approach looks good; really excited for it to use for my own subseasonal-to-seasonal forecast verification.
These comments were incorporated in https://github.com/bradyrx/climpred/pull/86.