question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

HindcastEnsemble.remove_bias() experimental for NWP leads

See original GitHub issue

Describe the bug

  • cross_validate=True doesnt work at all, if non-annual leads
  • unsure about the behaviour in general for non-annual leads
  • likely some completely different approach to bias reduction like smoothing needs to be implemented

became apparent in #603

Code Sample

requires #603 #529

with climpred.set_options(seasonality="dayofyear"):
        dayofyear_seasonality = hindcast.remove_bias(
            alignment=alignment, cross_validate=cross_validate
        )
with climpred.set_options(seasonality="weekofyear"):
        weekofyear_seasonality = hindcast.remove_bias(
            alignment=alignment, cross_validate=cross_validate
        )
assert not weekofyear_seasonality.get_initialized().identical(
        dayofyear_seasonality.get_initialized()

Expected behavior

  • reduce bias with bias only from seasonality, e.g. initialized.init.dt.dayofyear or initialized.init.dt.month
  • enable cross_validate=True: dont bias reduce initialization with that years bias

How to approach

  1. Write down how bias reduction is supposed to work
  2. Implement code

Easier to implement once #575 is merged: bias is calculated in time but named init

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:8

github_iconTop GitHub Comments

1reaction
judithbernercommented, Apr 16, 2021

Here is some code based on Riley’s and updated by Abby. My feeling is it’s not the latest version … https://github.com/judithberner/climpred_CESM1_S2S/blob/main/0.03_generate_member_anomalies_S2S.ipynb @abjaye

0reactions
aaronspringcommented, Aug 18, 2021

Closed by #645

Read more comments on GitHub >

github_iconTop Results From Across the Web

No results found

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found