Returned error from jose.importJWK is squashed

We had an issue where we were trying to debug the following error:

no valid key found in issuer's jwks_uri for key parameters {"kid":"jwa2A0ZH0Y4M_9HD-spX","alg":"RS256"}

The error is thrown at openid-client/lib/helpers/issuer.js:94:11.

After digging some time, I located the real source: https://github.com/panva/node-openid-client/blob/b3c0f3c5f800253dfd5fd793c63faccc0951148e/lib/helpers/keystore.js#L231

Our bug was missing “n” (modulus) and “e” (exponent) in some dev jwks keys. Because the error was squashed though, we could not see what happened.

I’ll be willing to make a PR for this if the owners agree the errors should be handled differently.

[simon-dk]

Thats a great point, and if that is the case it would of course not make sense to throw an error. A tiny bit more info in the log would have saved my day though. I’ll leave it at that and close this issue. Others who might get the same error now has a chance of reading about it here 🙃

It is not that common that authorization servers don’t know how to well form a JWK 😉

😄 Gladly it was some dev keys in a dev environment, not sure how they were generated, but I’ll have to look into that next.

[panva]

Likewise the error from jose is only ever good in one scenario that you happened to fall under but would completely throw off developers in others. It is not that common that authorization servers don’t know how to well form a JWK 😉