Completions unexpectedly add parentheses

Copied from https://github.com/microsoft/vscode-python/issues/15858.

Environment data

• VS Code version: 1.55.0
• Extension version (available under the Extensions sidebar): 2021.3.680753044
• OS and version: Ubuntu 20.04 LTS
• Python version: 3.7, deadsnakes
• Type of virtual environment used: virtualenv
• Value of the python.languageServer setting: JediLSP

Expected behaviour

class Thing: pass

Th<tab> # should complete to:
Thing|     # cursor after completed word

Actual behaviour

class Thing: pass

Th<tab> # should complete to:
Thing(|)  # cursor between completed parens

As far as I can tell this is specific to the JediLSP integration – changing my language server to Jedi results in the expected completion.

It looks like this may also vary by Python version – in another codebase I’m working on (in a Python 3.5 virtualenv) I don’t get this behaviour.

I can maybe see why this is maybe useful if you’re planning to construct an instance or calling a function, though there are many other places where callable symbols are used in which you don’t want this to happen – passing them as callbacks and type annotations for example.

[GalaxySnail]

In case you’re interested in tweaking anything, here’s where snippet logic is implemented in this codebase: https://github.com/pappasam/jedi-language-server/blob/main/jedi_language_server/jedi_utils.py#L284

I think it’s https://github.com/pappasam/jedi-language-server/blob/1d30a5ae7fd441880a9f3343911f1bfef370bd40/jedi_language_server/jedi_utils.py#L284 (the get_snippet_signature function).

If the line number is necessary, it will be better to reference a commit hash (or a tag) than a branch.

[pappasam]

@PeterJCLaw since this is now being tracked elsewhere, I’m going to close this issue here. Please let me know if you disagree!