Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Setting up "Models" section

See original GitHub issue

Hi! Is there an opportunity to change the “Models” section?

Currently, I have the following one (on this commit):

I’m not an experienced Swagger user but I think the issues are:

The T model should not be presented.
minimum: null/maximum: null for string and boolean seem redundant.
minimum: -2147483648 for id: int32 isn’t appropriate, I want it to start with 0.
kotlin.collections.List is strange, it’s a simple JSON array…
io.github.servb.eShop.util.OptionalResult<io.github.servb.eShop.route.product.v1.ProductUsable> has the data: T field, but data: io.github.servb.eShop.route.product.v1.ProductUsable is more logical here.

I’ve briefly checked the annotations but haven’t found suitable ones.

Issue Analytics

State:
Created 4 years ago
Comments:8 (1 by maintainers)

Top GitHub Comments

1reaction

Wicparcommented, Mar 4, 2020

@SerVB I changed the model acquisition system in the new release. Please verify if your issue persists or not.

0reactions

Wicparcommented, Mar 13, 2020

these are separate issues… Currently the model is made with data classes and serialised from it. I’ll have to change the whole model system to make it work like that. This can be quick fixed with a separate object mapper that serialises it to string in the openapi.json endpoint. Also, currently there are no @min @max annotations. Though it can be added quite rapidly iirc.