Binary imcompatibility between 3.7.0 and 3.7.1

Hello,

It seems that better-files versions of 3.7.0 and 3.7.1 are binary imcompatible.

This is manifested when using mixed version of better-files in project (one is pulling 3.7.0 and other 3.7.1):

java.lang.NoSuchMethodError: 
better.files.File.glob$default$3(Ljava/lang/String;Z)Lbetter/files/File$PathMatcherSyntax;

This seems to be caused by PR #290 which added new argument to the glob.

Could it be possible to release 3.7.2 without #290 and 3.8.0 with #290. If this this is too much trouble, then it might be good to add note to the release notes.

I also reviewed the PR and didn’t notice this - c’est la vie.

[pathikrit]

v3.8.0 is released and should mitigate this

[avdv]

better files considers it a minor version bump if extra default parameters are added (I know it can still break curried usages but in most other cases your code will just still work)

That’s not true. This breaks binary API compatibility in any case. You changed a 2-arity function into a 3-arity one (minus the implicit arg). Once compiled, the JVM wants to call either an 2-arity or 3-arity function.

The default argument only makes it source compatible in regard to the older version since default arguments are handled by the compiler. So you have to recompile your code if you switch from 3.7.0 to 3.7.1.

If you use one library compiled with 3.7.0 and another compiled with 3.7.1 you’re in trouble.

To keep binary compatibility you could overload the method instead, without a default argument:

  def globRegex(
      pattern: Regex,
      includePath: Boolean = true
    )(implicit
      visitOptions: File.VisitOptions = File.VisitOptions.default
    ): Iterator[File] = globRegex(pattern, Int.MaxValue, includePath)

  def globRegex(
      pattern: Regex,
      maxDepth: Int,
      includePath: Boolean = true
    )(implicit
      visitOptions: File.VisitOptions = File.VisitOptions.default
    ): Iterator[File] = ...