question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

No changes still produce changes

See original GitHub issue

Given

<script src="foo.js"></script>
<script>console.log('foo')</script>

Morph this into

<script>console.log('foo')</script>

Morhdom seems to be doing two changes in scenarios like this.

  1. It will morph the removed script tag that has a src attribute into the other inline script tag.
  2. It will discard the second script tag.

The “right” thing to do, would be to use the best match (e.g, its more likely that node 1 was removed here rather than node 1 was mutated into the properties of node 2, and node 2 was removed).

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Comments:9 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
snewcomercommented, Sep 21, 2019

No action items. Closing for now…

0reactions
caspervonbcommented, Jan 25, 2017

@patrick-steele-idem Am already doing that, but the issue is more on a whole IMHO. Take a collection of <li> items, remove one. All of the items are then repurposed (first match is used) rather than the one item removed, semantically this seems like the wrong thing to do.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Git says there are changes but there are none - Stack Overflow
If something is different here, git status prints the file's name and tells you that this is a change that is not yet...
Read more >
GitHub Desktop is showing changes but I havent made ...
I just closed GitHub Desktop and re-opened it and it's still showing 1 file under changes. Any way I can resolve this with...
Read more >
Git commit, no changes detected (problem solved)
Hi all : After I edit a file and commit, it always shows " No changes detected ", and the file I edit,...
Read more >
Why Change Programs Don't Produce Change
Successful change efforts focus on the work itself, not on abstractions like “participation” or “culture.” Once general managers understand the logic of this ......
Read more >
Make changes to an existing data source in Power Pivot
Table and column mappings. Remove references to columns that are no longer used. The tables, views, or columns you get from the external...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found