question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Adding isManagedSidebar causes warnings

See original GitHub issue

Describe the issue. What is the expected and unexpected behavior? Adding isManagedSidebar prop causes warnings/errors in header

index.js:2177 Warning: React does not recognize the `isManagedSidebar` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `ismanagedsidebar` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
    in header (created by Context.Consumer)
    in PageHeader (created by VerticalPage)
    in div (created by Page)
    in Page (created by VerticalPage)

and in the sidebar

Warning: React does not recognize the `isManagedSidebar` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `ismanagedsidebar` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
    in div (created by Context.Consumer)
    in PageSidebar (created by VerticalPage)
    in div (created by Page)
    in Page (created by VerticalPage)
    in VerticalPage (created by ErrorBoundary)

Please provide the steps to reproduce. Feel free to link CodeSandbox or another tool.

just add isManagedSidebar to the example here: https://github.com/patternfly/patternfly-react/blob/master/packages/react-core/src/components/Page/examples/Page.md

     <PageHeader
        isManagedSidebar
        logo="Logo"
        logoProps={logoProps}
        headerTools={<PageHeaderTools>header-tools</PageHeaderTools>}
        showNavToggle
        isNavOpen={isNavOpen}
        onNavToggle={this.onNavToggle}
      />

Is this a bug or enhancement? If this issue is a bug, is this issue blocking you or is there a work-around? This is a bug

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
MariaAgacommented, Jul 19, 2020
0reactions
boaz0commented, Jul 19, 2020

OK - if you want PF4 to control the sidebar state (open/close) pass isManagedSidebar in the Page component. I do not see any reason to put isManagedSidebar in PageHeader and seems like a mistake.

//cc @dtaylor113 - can you take a look at this? thanks.

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to add warnings and errors to your code using # ...
Sometimes it's important to add warnings and even errors to your code. ... Both #warning and #error are useful for different reasons:.
Read more >
Release notes
Alert : Fixed to prevent error being thrown when using invalid variant (#8229). Banner: Added support for status icons (#8195); Updated tests to...
Read more >
c++ - Add my own compiler warning
I'm using Visual Studio 2022 with compiling VS2017 projects, if this makes a difference. Share.
Read more >
Configuring Errors and Warnings in C# - CodeOpinion
I noticed the issue because it was a compiler warning CS4014 and was highlighted in code. I immediately fixed the issue, however, ...
Read more >
Errors and warnings pane very unreliable.
@Brian Ross When we added new analysis (green squiggles, etc.) we kept the ability to turn it off in case it was causing...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found